Uploaded image for project: 'TrueNAS'
  1. TrueNAS
  2. NAS-107270

Critical Permissions issue in ZFS on FreeBSD

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done (View Workflow)
    • Priority: Low
    • Resolution: Complete
    • Affects Version/s: 12.0-BETA2, 12.0-BETA1
    • Fix Version/s: 12.0-RC1, 12.0-BETA2.1
    • Component/s: ZFS
    • Labels:
      None
    • Impact:
      Critical

      Description

      Issue 1:
      Users are always granted permissions to cd into a directory. The check for whether execute is present on directories is a de-facto no-op. This cannot be mitigated without upgrading. Even setting an explicit "deny - execute" NFSv4 ACE will be bypassed.

      Issue 2:
      All ACEs for the owner_group (group@) and regular groups (group:<foo>) are granted the current user. This means that POSIX mode 770 is de-facto 777, and the below ACL is also de-facto 777 because the groupmember check for builtin_administrators returns True.
       

      root@TNBETA1[~]# getfacl testfile  
      # file: testfile
      # owner: root
      # group: wheel
      group:builtin_administrators:rwxpDdaARWcCos:-------:allow


       

      This currently affects FreeBSD port of openzfs.
      12.x BETA1/BETA2/MASTER and sysutils/openzfs-kmod are impacted.

      Status:  Resolved

      Links:

        Attachments

          Attachments

            JEditor

              Activity

                People

                Assignee:
                jt Justin Pennington
                Reporter:
                jt Justin Pennington
                Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                  Dates

                  Created:
                  Updated:
                  Resolved: