Uploaded image for project: 'TrueNAS'
  1. TrueNAS
  2. NAS-108168

Fix SMB2 AAPL extension negotiation

    XMLWordPrintable

Details

    • Defect
    • Status: Done (View Workflow)
    • Low
    • Resolution: Complete
    • None
    • 12.0-U1
    • None
    • None

    Description

      PR: https://github.com/freenas/freenas/pull/5953

      12.0 abstracted away from exposing explicit vfs module configuration
      to users (instead opting to use checkboxes). In cases where we couldn't
      cleanly migrate the user's VFS objects to our new feature-based config
      (acls, streams, etc), we dumped the params into SMB share auxiliary
      parameters. This preserves user's existing behavior (pre-12.0), but
      can cause issues with time machine support if user opts to add a
      time machine share at a later date (or has inconsistently-migrated
      shares) since support for the SMB2 protocol extensions is determined
      on the first SMB2 tree connect. This means that all shares must have
      vfs_fruit enabled (even ones with VFS objects in auxiliary parameters)
      if users have them on any other share.
      To address this potential issue, check for "vfs objects" lines when
      parsing auxiliary parameters and add vfs_fruit if the global option
      "aapl_extensions" is set.

      Attachments

        Attachments

          JEditor

            Activity

              People

                awalker Andrew Walker
                bugclerk Bug Clerk
                Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: