Uploaded image for project: 'TrueNAS'
  1. TrueNAS
  2. NAS-108528

samba: improve aio scalability

    XMLWordPrintable

    Details

    • Type: Defect
    • Status: Done (View Workflow)
    • Priority: Low
    • Resolution: Complete
    • Affects Version/s: None
    • Fix Version/s: 12.0-U1
    • Component/s: None
    • Labels:
      None

      Description

      PR: https://github.com/freenas/ports/pull/911

      • Simplify code path / remove special tevent_add_fd flag to do AIO
        and instead perform AIO directly.
      • Add fallback to synchronous pread()/pwrite()/fsync() if AIO path
        fails with EAGAIN.
      • Grow size of kevents array as we hit overload situation. Loop on
        kevent() calls while overloaded to avoid an extra call to
        talloc_stackframe_pool() / talloc_free().
      • Discharge pending immediate event queue after callback in case
        callback for fd / aio event submits an immediate to the queue.
      • When the tevent timer is being processed, the destructor will
        be removed prior to TALLOC_FREE(te) and so exiting destructor here
        will not leak memory. This is to avoid potential for NULL dereference
        in process_tevent_timer.

        Attachments

          Attachments

            JEditor

              Activity

                People

                Assignee:
                releng Triage Team
                Reporter:
                bugclerk Bug Clerk
                Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                  Dates

                  Created:
                  Updated:
                  Resolved: