Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

gpart add and gpart bootcode generate xml

Description

After investigation it has been shown that calling "gpart add" and "gpart bootcode" commands eventually generate geom xml (kern.geom.confxml) which is especially painful on large systems.

When middleware formats disks to be added to a zpool we're calling "gpart add" twice and "gpart bootcode" once which means xml is being generated 3 times per disk.

This ends up spinning the g_event thread at 100%. Attaching flamegraph showing this scenario.

Problem/Justification

None

Impact

None

Activity

Show:

Alexander Motin March 12, 2022 at 5:42 PM

Got review, committed upstream and merged.

Alexander Motin March 11, 2022 at 2:51 AM

While the last patch is in review, merged the previous ones into 13.0-RC1, that should remove 5 out of 7 XML fetches per disk partitioning.

Alexander Motin March 11, 2022 at 2:28 AM

The last planned patch to remove most of remaining full confxml calls from gpart and other geom tools is pushed for review: https://reviews.freebsd.org/D34529

Alexander Motin March 8, 2022 at 7:02 PM

Removed confxml fetch from `gpart bootcode -b` (without -p):
https://cgit.FreeBSD.org/src/commit/?id=5c20bfc78706d2fe6e262ddb55af0a8b928d3835

Alexander Motin March 8, 2022 at 5:18 PM

Fixed oddity, fetching confxml extra time for ANY GEOM command without good reason:
https://cgit.FreeBSD.org/src/commit/?id=5678114cd8b310bd6f0a5699f036fc5b18addd65

Complete

Details

Assignee

Reporter

Labels

Time remaining

0m

Components

Fix versions

Affects versions

Priority

Katalon Platform

Created February 24, 2022 at 5:42 PM
Updated July 1, 2022 at 5:53 PM
Resolved March 12, 2022 at 5:42 PM