Bug fixes for VM NIC device

Hi,

like explained in this thread I experienced a problem in FreeNAS 11.3 beta 1.
https://www.ixsystems.com/community/threads/11-3beta1-cannot-create-bhyve-guest-attached-to-bridge.80111/

This is what I did:

• upgraded from 11.2U6 to 11.3Beta1

• changed network configuration to just DHCP / autoconfig on em0 to

  • em0 without any special config

  • create vlan(5 in my case) interface with parent em0

  • create bridge and choose vlan5 with DHCP and autoconf

  • then I hit submit

slightly offtopic:
You might want to consider to extend the windows of one minute to a slightly longer period. I had to hit submit, run into the basement, change the cable to the new port which is now tagged instead of untagged. Run upstairs, try to find out the new IP, since the device receicved a new one and then login to FreeNAS again to hit the button to keep the changes. Otherwise it would have been reverted, which is per se a very nice function but it's just too short.

back to topic:
The network configuration worked very good so far. Next:

• create a bhyve guest and choose the newly created bridge.

• try to start the guest. It won't start though, I get this error:

[Errno 22] Invalid argument
Error: Traceback (most recent call last):
File "/usr/local/lib/python3.7/site-packages/middlewared/main.py", line 174, in call_method
result = await self.middleware.call_method(self, message)
File "/usr/local/lib/python3.7/site-packages/middlewared/main.py", line 1162, in call_method
return await self._call(message['method'], serviceobj, methodobj, params, app=app, io_thread=False)
File "/usr/local/lib/python3.7/site-packages/middlewared/main.py", line 1110, in _call
return await methodobj(*args)
File "/usr/local/lib/python3.7/site-packages/middlewared/schema.py", line 949, in nf
return await f(*args, **kwargs)
File "/usr/local/lib/python3.7/site-packages/middlewared/plugins/vm.py", line 1001, in start
await self._manager.start(vm)
File "/usr/local/lib/python3.7/site-packages/middlewared/plugins/vm.py", line 53, in start
list(done)[0].result()
File "/usr/local/lib/python3.7/site-packages/middlewared/plugins/vm.py", line 186, in run
await self.bridge_setup(tapname, tap, attach_iface)
File "/usr/local/lib/python3.7/site-packages/middlewared/plugins/vm.py", line 429, in bridge_setup
bridge.add_member(attach_iface)
File "netif.pyx", line 1204, in netif.BridgeInterface.add_member
File "netif.pyx", line 1222, in netif.BridgeInterface.bridge_cmd
OSError: [Errno 22] Invalid argument