Google Team Drives no longer work in 11.3-U3

Description

It appears FreeNAS has included a version of rclone in 11.3-U3 that is affected by this bug:

https://github.com/rclone/rclone/issues/4051

The result of including this version of rclone, failing to test it and then shipping it in update 11.3-U3 means that Google Team Drives used for Cloud Sync tasks no longer work. When the Cloud Sync tasks run, they upload to my personal Google Drive rather than the shared Team Drive.

Here's the rclone config used by FreeNAS for one of these now-broken Cloud Sync tasks. I've removed my token and fudged the team_drive ID, but you can see how the config includes both team_drive and root_folder_id, which is the root of the bug.

[remote]
token = {"access_token":"","token_type":"Bearer","refresh_token":"","expiry":"2020-05-21T08:59:59.458838805-05:00"}
team_drive = 0AI_3p73b543uXXXXXX
client_id =
client_secret =
type = drive
root_folder_id = root
folder = tank/iocage
fast_list = True

What is the best way to downgrade rclone so I can resume my Cloud Sync tasks? Is that even possible? Is there a way to pass --drive-root-folder-id "" to rclone?

Problem/Justification

None

Impact

None

SmartDraw Connector

Katalon Manual Tests (BETA)

Activity

Show:

Bug ClerkJune 9, 2020 at 3:49 PM

Bug ClerkJune 9, 2020 at 3:15 PM

Scott WMay 26, 2020 at 2:30 PM

The updated patch works.  Here's a temporary rclone.conf:

Vladimir VinogradenkoMay 26, 2020 at 1:38 PM

 sorry, patch updated

Scott WMay 25, 2020 at 5:29 PM

Yes, downloading a copy of rclone 1.50.1 for FreeBSD from the rclone Github release page worked.  Sorry, it's disruptive for me to reboot FreeNAS to check what version is used in an older update.

If you check the link to the rclone bug report, you will see the issue is introduced by this commit:

https://github.com/rclone/rclone/commit/473a437163027ae6116b948a71d2de467890f2d2

It's a pretty self explanatory commit, if not buggy.  But if you are saying that between U2 and U3, FreeNAS began including the "root_folder_id" in it's rclone.conf temporary files, then this would also trigger this issue.  If FreeNAS was using the same version, but did not include "root_folder_id" in the config, the issue does not occur.

As far as that fix goes, it doesn't seem to work.  I found that file at /usr/local/lib/python3.7/site-packages/middlewared/rclone/remote/google_drive.py and modified it and restarted the middlewared service. But the temporary rclone.conf still contains root_folder_id:

Complete

Details

Assignee

Reporter

Due date

Components

Fix versions

Affects versions

Priority

More fields

Katalon Platform

Created May 21, 2020 at 1:41 PM
Updated July 1, 2022 at 4:53 PM
Resolved June 9, 2020 at 3:49 PM