SMB Service Save - TypeError occurs

12.0 PR: https://github.com/freenas/freenas/pull/5535

12.1 PR: https://github.com/freenas/freenas/pull/5530

Hi Team

im seeing something similar to the above when trying to enable SMB1, see output below and image attached.

the error is instant it doesn't look like the command is completing.

was working before 12 - BETA2 update a few hours ago.

let me know if i can help with any other output?

ta

Error: Traceback (most recent call last):
File "/usr/local/lib/python3.8/site-packages/middlewared/main.py", line 137, in call_method
result = await self.middleware._call(message['method'], serviceobj, methodobj, params, app=self,
File "/usr/local/lib/python3.8/site-packages/middlewared/main.py", line 1191, in _call
return await methodobj(*prepared_call.args)
File "/usr/local/lib/python3.8/site-packages/middlewared/service.py", line 356, in update
rv = await self.middleware._call(
File "/usr/local/lib/python3.8/site-packages/middlewared/main.py", line 1191, in _call
return await methodobj(*prepared_call.args)
File "/usr/local/lib/python3.8/site-packages/middlewared/schema.py", line 973, in nf
return await f(*args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/middlewared/plugins/smb.py", line 596, in do_update
await self.validate_smb(new, verrors)
File "/usr/local/lib/python3.8/site-packages/middlewared/plugins/smb.py", line 520, in validate_smb
if not await self.__validate_netbios_name(new[i]):
File "/usr/local/lib/python3.8/site-packages/middlewared/plugins/smb.py", line 229, in __validate_netbios_name
return RE_NETBIOSNAME.match(name)
TypeError: expected string or bytes-like object

Even if I change this to a valid workgroup (14june) then this error still occurs.  I also tried replacing every entry (including entering something in empty fields and deleting) - still the same error.

14JUNE.LOCAL
^^^ This is an invalid workgroup.