I've recently upgraded from 11.3-U4.1 to 12.0 RC1 and unfortunately the samba previous versions function seems to have been broken again.
The ignore_empty_snapshot VFS module setting is completely ignored.
Running samba with debug logging I can see a message (presumably from `shadow_copy_zfs_get_shadow_copy_zfs_data` that 0 snapshots were retrieved for a share.
Following on from above with the snapshot cache disabled if I repeat the previous versions lists I can probably 50/50 get a snapshot list to return and the above debug message states that it returned X amount of snapshots. (race condition somewhere?)
I've also seen warning log messages that the snapshot path is outside of the current share with seemingly an attempted access to another volumes snapshots. Not going anything concrete on this other than we've seen it several times but haven't managed to narrow it down.
To my knowledge this was all working well with 11.3-U4.1 and has done since some VFS fixes were applied around U1-2.
Not sure how we're doing debugs these days but I can get one no problem.
Original issue was addressed by large-scale work on shadow copies prior to U1 release.
Andrew Walker
January 5, 2021 at 4:00 PM
Okay. I'll address that in a separate ticket.
Ben Hughes
January 5, 2021 at 3:24 PM
The only things I can see is the ignore_empty_snapshot setting not working when set to false, otherwise yes everything seems to be working as expected.
Andrew Walker
January 5, 2021 at 2:21 PM
There is one last edge case that will be fixed in the next release (child datasets located inside share paths). Otherwise is everything working okay?
Ben Hughes
December 11, 2020 at 1:39 PM
Hi Andrew, from a quick test it's definetly a massive improvement and appears to be working as expect for snapshots that aren't empty and it seems to be resolving the paths correctly for all the scenarios i've tried now.
I need to do some more testing with the ignore_empty_snapshots setting set to false as I don't think that's working as it was before, it's still ignoring the empties. But I want to test that more as I only had a quick go with it.
I've recently upgraded from 11.3-U4.1 to 12.0 RC1 and unfortunately the samba previous versions function seems to have been broken again.
The ignore_empty_snapshot VFS module setting is completely ignored.
Running samba with debug logging I can see a message (presumably from `shadow_copy_zfs_get_shadow_copy_zfs_data` that 0 snapshots were retrieved for a share.
Following on from above with the snapshot cache disabled if I repeat the previous versions lists I can probably 50/50 get a snapshot list to return and the above debug message states that it returned X amount of snapshots. (race condition somewhere?)
I've also seen warning log messages that the snapshot path is outside of the current share with seemingly an attempted access to another volumes snapshots. Not going anything concrete on this other than we've seen it several times but haven't managed to narrow it down.
To my knowledge this was all working well with 11.3-U4.1 and has done since some VFS fixes were applied around U1-2.
Not sure how we're doing debugs these days but I can get one no problem.