Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

replication allows mountroot to be set to /

Description

Customer setup a pull type replication to a Linux-based ZFS workstation.

His replication was for his boot pool.

The resulting replicated dataset has a mountroot of /, which ends up mounting on /mnt, blocking access to other datasets underneath.

Discussion in chat was that we should block some properties from being replicated.

Problem/Justification

None

Impact

None

SmartDraw Connector

Katalon Manual Tests (BETA)

Activity

Show:

Vladimir Vinogradenko 
January 6, 2021 at 3:59 PM

Vladimir Vinogradenko 
January 6, 2021 at 2:00 PM

if we set data/my/dataset mountpoint to data/my/dataset-custom and then try to get data/my/dataset mountpoint like we always do (os.path.join('/mnt', dataset_name)), we'll get '/mnt/data/my/dataset' instead of '/mnt/data/my/dataset-custom', so if we allow mountpoints, we'll need to find and fix all the code that does that.

William Gryzbowski 
January 6, 2021 at 1:53 PM

Break how? Please explain.

Vladimir Vinogradenko 
January 6, 2021 at 1:17 PM

I've totally missed that! Nevertheless, I think that

> We often get dataset path just as '/mnt/$dataset'. This will all break. I also don't see any benefit in allowing custom mountpoints.

Is still true and I still think that we should discard all mountpoints when receiving.

William Gryzbowski 
December 24, 2020 at 8:19 PM

we never mount anything inside /, because our pool is imported with -R /mnt, so everything is inside /mnt, no matter what

Complete

Details

Assignee

Reporter

Labels

Impact

Support Ticket

Components

Fix versions

Priority

More fields

Katalon Platform

Created December 22, 2020 at 5:55 PM
Updated July 1, 2022 at 4:59 PM
Resolved January 6, 2021 at 3:59 PM