Job leak in middlewared

Description

Jobs with locks are held in JobSharedLock structure. It keeps track of jobs in a list.

JobsQueue.get_lock() is used to add jobs to job-specific locks. Somehow the same job entry enters the JobSharedLock.queue, howewer, JobSharedQueue.remove() only removes the first item present in the queue.

Problem/Justification

None

Impact

None

Activity

Show:

Bug Clerk

March 30, 2022 at 9:32 PM

22.02.1 PR: https://github.com/truenas/middleware/pull/8681

Bug Clerk

March 30, 2022 at 9:32 PM

13.0 PR: https://github.com/truenas/middleware/pull/8680

Bug Clerk

March 11, 2022 at 4:58 PM

22.12 PR: https://github.com/truenas/middleware/pull/8521

Richard Kojedzinszky

March 11, 2022 at 9:14 AM

Meant to write that the same job might enter the lock queue multiple times, howewer, the remove operation removes the first entry only. One possible double-entry is when checking for the queue length in https://github.com/truenas/middleware/blob/master/src/middlewared/middlewared/job.py#L92. The existing queue elements are checked, and a get_lock() is called with them, efffectively adding them once more to the queue.

Bug Clerk

March 11, 2022 at 9:09 AM

22.12 PR: https://github.com/truenas/middleware/pull/8515

Resize issue view side panel