OpenVPN autostart not working

12.0 PR: https://github.com/freenas/freenas/pull/5354

12.1 PR: https://github.com/freenas/freenas/pull/5352

I think I identified the problem.

Both openvpn_client and openvpn_server init scripts are symlinks to "/usr/local/etc/rc.d/openvpn"

If you look at the service script template, you can see that during boot and shutdown, $name is define as $_file. This results in the both service files checking for openvpn_enable, openvpn_configfile, ... which are not defined.

When manually starting the service, $name is defined as ${0##*/} which correctly check for openvpn_client_enable, ... and openvpn_server_enable, ...

So either the service script template needs to be changed to not use $_file, or the openvpn service files should be deduplicated instead of symlinking to the same openpvn file.

To be more precise, I only have two errors at boot time:
1) "Failed to establish libvirt connection" which is maybe linked to this bug?
2) "No zpools found! Please create one before using iocage" which is caused by iocage not being able to start jails because my iocage dataset is encrypted.

From what I see, openvpn_client and openvpn_server are two services running directly on the host so these errors should not be related to the OpenVPN services not starting at boot time.

Here is a copy of the above mentioned errors from middlewared.log:

The services start perfectly fine when manually clicking the "Running" switch in Services.

There is nothing related to OpenVPN in the logs at boot time.

I don't know where / how you implemented services autostart, but it's somehow missing for the new OpenVPN services.